Hey bud, here's my take having had quite a bit of experience with most of your choices.
E90 330d 2005-2008 (pre-facelift) - I had a 2006 330d Auto which I bought on 120 000km, bought the car and drove it stock for about 5000km, it was a good performer but lacking something, so did software and following that downpipe, intercooler and straight through exhaust. Man did this change the car completely, it went from a good all rounder to a proper machine in conjunction with being an amazing all rounder. With the exhaust done it sounded mad, people couldn't believe that it was a diesel. I drove it hard and still managed 8.5-9l/100km with mostly urban driving. I sold the car on about 145 000km and didn't have any issues. If you buy one of these, some mods are a must!
E90 330d 2009 onwards (facelift) - My dad's had a 2010 330d Auto from new, and has now reached 160 000km. I've driven this car on a lot of occasions and it really has impressed me. The only major issue he's had was a gearbox issue around 135 000km which was a R15k repair. Everything else has just been normal servicing. This car stock is already a fast machine and we had runs where my dad wasn't far behind my fully modded 06 330d. He averages 6.5-7l/100km with mixed driving. As Karsh has said as well, do some mods to this 330d and it becomes a proper performer and will see off a stock 335i. This car for me, even in stock form, is the ultimate all rounder for the price.
E90/93 330i - my brother has a 2009 330i convertible auto - I've also driven this car a lot and other 330i's in the past, and as gents have said, the NA straight six sound is awesome, and if you live at the coast I would seriously consider it, but if you live up here on the reef you are going sometimes wish it had a little bit more, that's not to say it's slow, not at all, it runs well but another 25kw would make it that much better. And to get 25kw more out of this engine is going to be very difficult. He gets around 12.5l/100km driving nicely but his is a convertible and auto. As mentioned as well, if you were to choose a 330i, manual is the only choice, and you should get about 11l/100km average on the fuel consumption.
E90 335i - I now have a 2009 335i auto, I drove this car for about 3000km stock and it was an absolutely amazing car, fuel consumption was around the 10.5l/100km mark and it had more than enough power, it was quick! I did buy it however, with the intention of doing mods which I have done and now it is unbelievably quick! Fuel consumption is now around the 12.5-13l/100km mark as the power is addictive. I don't use it as a daily as I have a Ranger which I use mostly during the week.
E90 320d LCI - haven't owned one but have driven a couple, the motor in these cars is much better than the earlier versions and it goes really well! Up here on the reef you will stay with a 330i from pull away till about 140km/h I reckon, obviously after that the bigger engine will start pulling away. My friend used to average 7.5l/100km and he pushed his car.
Out of these choices, if you can find a 330d lci for around R180k or push your budget to R190/200k this would be my first choice, even if it's got 120k km don't stress too much. Second would be an '08 pre-facelift and then do some mods!:coolShake: